Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [UWP][WinUI] Support for RegionManager.IsInDesignMode #2419

Merged
merged 1 commit into from
Apr 27, 2021
Merged

fix: [UWP][WinUI] Support for RegionManager.IsInDesignMode #2419

merged 1 commit into from
Apr 27, 2021

Conversation

jeromelaban
Copy link
Contributor

@jeromelaban jeromelaban commented Apr 27, 2021 •
edited
Loading

Description of Change

Implement the support for RegionManager.IsInDesignMode

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

None

Behavioral Changes

This will indicate prism to stop processing regions when hosted in the XAML designed.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit 4a3f400 into PrismLibrary:master Apr 27, 2021
@dansiegel dansiegel added this to the Prism 8.1 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianlagunas brianlagunas brianlagunas approved these changes

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] RegionManager.IsInDesignMode is wrong for UWP, causing a null-ref in design mode when setting RegionName
3 participants
@jeromelaban @brianlagunas @dansiegel